Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 206005: print out the tests that were run into tests_run.txt for easier postprocessing (Closed)

Created:
11 years, 3 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

print out the tests that were run into tests_run.txt for easier postprocessing BUG=none TEST=purify layout tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26599

Patch Set 1 #

Patch Set 2 : add a comment #

Total comments: 1

Patch Set 3 : added a comment and explicitly closed the file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M webkit/tools/layout_tests/layout_package/test_shell_thread.py View 1 2 3 chunks +10 lines, -0 lines 0 comments Download
M webkit/tools/layout_tests/run_webkit_tests.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Erik does not do reviews
11 years, 3 months ago (2009-09-15 00:01:32 UTC) #1
Pam (message me for reviews)
http://codereview.chromium.org/206005/diff/2001/3001 File webkit/tools/layout_tests/layout_package/test_shell_thread.py (right): http://codereview.chromium.org/206005/diff/2001/3001#newcode252 Line 252: tests_run_file = open(tests_run_filename, "a") When does the file ...
11 years, 3 months ago (2009-09-15 00:14:20 UTC) #2
Erik does not do reviews
I dislike having explicit closes through multiple return paths, so in this case I was ...
11 years, 3 months ago (2009-09-18 17:49:55 UTC) #3
Pam (message me for reviews)
11 years, 3 months ago (2009-09-18 18:09:54 UTC) #4
LGTM.

- Pam

Powered by Google App Engine
This is Rietveld 408576698