Removing the app launcher button on ChromeOS

Removing the app launcher button in the ChromeOS browser and making the app launcher pinned to the location bar.

BUG=3190
TEST=The app launcher icon on the top-left corner of the browser should
     be gone.  Opening a new tab by pressing the + button or typing
     CTRL-T should bring the app launcher, it should be located on top
     of the location bar.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47314

[Jay Civelli, 2010-05-12 21:43:50]

Finnur, could you review:
chrome/browser/views/info_bubble.h
chrome/browser/views/info_bubble.cc
chrome/browser/views/pinned_contents_info_bubble.h
chrome/browser/views/pinned_contents_info_bubble.cc

Scott, could you review the rest?

[sky, 2010-05-12 21:53:15]

LGTM

[Finnur, 2010-05-12 23:01:32]

LGTM

[Jay Civelli, 2010-05-13 20:43:40]

Scott,
I had to add a switch to disable the new behavior of showing the app launcher
when creating a new tab and use it for tests, as tests expect the old behavior.
We'll have to fix the tests when/if the new behavior becomes the default on all
platforms.

Could you look again at:
browser.[h,cc]
chrome/browser/views/tabs/tab_strip.cc
chrome/common/chrome_switches.[h,cc]
chrome/test/in_process_browser_test.cc
chrome/test/ui/ui_test.cc 

Thanks.

Jay

[sky, 2010-05-13 22:32:38]

http://codereview.chromium.org/2060004/diff/27001/28003
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2060004/diff/27001/28003#newcode1059
chrome/browser/browser.cc:1059: bool use_apps_panel =
command_line->HasSwitch(switches::kAppsPanel);
Can you move this into defaults.h. Hopefully it'll make the code a little easier
to read.

http://codereview.chromium.org/2060004/diff/27001/28012
File chrome/browser/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/2060004/diff/27001/28012#newcode958
chrome/browser/views/tabs/tab_strip.cc:958: NavigationController& controller =
I landed a change that moved this code, you'll need to put it in
BrowserTabStripController::CreateNewTab

http://codereview.chromium.org/2060004/diff/27001/28012#newcode960
chrome/browser/views/tabs/tab_strip.cc:960: Browser* browser =
Browser::GetBrowserForController(&controller, NULL);
Can you use model_->GetSelectedTabContents()->GetBrowser()?

[Jay Civelli, 2010-05-14 01:05:31]

I had to change a test (AutomationProxyVisibleTest.WindowGetViewBounds)
slightly.
It tests that the automation proxy GetViewBounds returns meaningful info, and
test the first tab x is more than 0.
This works on Windows because of the frame thickness and use to work on ChromeOS
because of the app launcher button.
Now that the app launcher is gone, since ChromeOS has a frame thickness of 0, it
failed.

http://codereview.chromium.org/2060004/diff/27001/28003
File chrome/browser/browser.cc (right):

http://codereview.chromium.org/2060004/diff/27001/28003#newcode1059
chrome/browser/browser.cc:1059: bool use_apps_panel =
command_line->HasSwitch(switches::kAppsPanel);
On 2010/05/13 22:32:39, sky wrote:
> Can you move this into defaults.h. Hopefully it'll make the code a little
easier
> to read.

Done! (Did not know we had a defaults.h)

http://codereview.chromium.org/2060004/diff/27001/28012
File chrome/browser/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/2060004/diff/27001/28012#newcode958
chrome/browser/views/tabs/tab_strip.cc:958: NavigationController& controller =
On 2010/05/13 22:32:39, sky wrote:
> I landed a change that moved this code, you'll need to put it in
> BrowserTabStripController::CreateNewTab

Done.

http://codereview.chromium.org/2060004/diff/27001/28012#newcode960
chrome/browser/views/tabs/tab_strip.cc:960: Browser* browser =
Browser::GetBrowserForController(&controller, NULL);
On 2010/05/13 22:32:39, sky wrote:
> Can you use model_->GetSelectedTabContents()->GetBrowser()?

There is no TabContents::GetBrowser() method.
I don't know any shorter way of getting the browser from the tab.

[sky, 2010-05-14 03:01:20]

LGTM with the following change.

http://codereview.chromium.org/2060004/diff/27001/28012
File chrome/browser/views/tabs/tab_strip.cc (right):

http://codereview.chromium.org/2060004/diff/27001/28012#newcode960
chrome/browser/views/tabs/tab_strip.cc:960: Browser* browser =
Browser::GetBrowserForController(&controller, NULL);
On 2010/05/14 01:05:31, Jay Civelli wrote:
> On 2010/05/13 22:32:39, sky wrote:
> > Can you use model_->GetSelectedTabContents()->GetBrowser()?
> 
> There is no TabContents::GetBrowser() method.
> I don't know any shorter way of getting the browser from the tab.
> 

Sorry, I meant:

model_->GetSelectedTabContents()->delegate()->GetBrowser().