Move non-linux specific code from base/linux_util to app/gtk_util...

Move non-linux specific code from base/linux_util to app/gtk_util
from sprewell


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47201

[Evan Martin, 2010-05-12 10:20:46]

http://codereview.chromium.org/2058004/diff/1/2
File app/app_paths.cc (right):

http://codereview.chromium.org/2058004/diff/1/2#newcode59
app/app_paths.cc:59: #if defined(OS_POSIX) && !defined(OS_MACOSX)
I think Mac uses pakfiles as well... why was this needed?

http://codereview.chromium.org/2058004/diff/1/5
File app/gtk_util.h (right):

http://codereview.chromium.org/2058004/diff/1/5#newcode36
app/gtk_util.h:36: uint8_t* BGRAToRGBA(const uint8_t* pixels, int width, int
height, int stride);
This is a sorta strange place for it, but the old place was strange too I guess.

[Peter Valchev, 2010-05-12 23:05:12]

http://codereview.chromium.org/2058004/diff/1/2
File app/app_paths.cc (right):

http://codereview.chromium.org/2058004/diff/1/2#newcode59
app/app_paths.cc:59: #if defined(OS_POSIX) && !defined(OS_MACOSX)
On 2010/05/12 10:20:47, Evan Martin wrote:
> I think Mac uses pakfiles as well... why was this needed?

I think it didn't find the pak file, this makes it find it in the same directory
as the executable... I'm not sure how the MacOS distribution works but since
this was OS_LINUX before, I'm reluctant to change it?

http://codereview.chromium.org/2058004/diff/1/5
File app/gtk_util.h (right):

http://codereview.chromium.org/2058004/diff/1/5#newcode36
app/gtk_util.h:36: uint8_t* BGRAToRGBA(const uint8_t* pixels, int width, int
height, int stride);
On 2010/05/12 10:20:47, Evan Martin wrote:
> This is a sorta strange place for it, but the old place was strange too I
guess.

Yeah, dunno what's a better place..

[Evan Martin, 2010-05-13 06:28:42]

Ah, I misread the diff.  LGTM then