Issue 2055008: Init: Start Update Engine at startup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2055008: Init: Start Update Engine at startup (Closed)

Created:
10 years, 7 months ago by adlr

Modified:
9 years ago

Reviewers:
Chris Masone

CC:
chromium-os-reviews_chromium.org, dneiss, adlr

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Init: Start Update Engine at startup Also related AU Fixes: - daemonize() for upstart - remember success in updating across runs of the process. - bug fixes: don't try to update if an update is in progress, clear actions out in Update Attempter when updating is complete. BUG=None TEST=on device testing

Patch Set 1 #

Total comments: 2

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -0 lines)			Patch
A	src/platform/init/update-engine.conf	View	1 chunk	+15 lines, -0 lines	0 comments	Download
M	src/platform/update_engine/main.cc	View	2 chunks	+5 lines, -0 lines	2 comments	Download
M	src/platform/update_engine/update_attempter.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	src/platform/update_engine/update_attempter.cc	View	4 chunks	+14 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

Chris, you already approved the conf file in another CL i haven't submitted, which this ...

10 years, 7 months ago (2010-05-10 22:42:12 UTC) #1

Chris Masone

lgtm w/nits http://codereview.chromium.org/2055008/diff/1/3 File src/platform/update_engine/main.cc (right): http://codereview.chromium.org/2055008/diff/1/3#newcode22 src/platform/update_engine/main.cc:22: DEFINE_bool(forground, false, foreground http://codereview.chromium.org/2055008/diff/1/3#newcode97 src/platform/update_engine/main.cc:97: if (!FLAGS_forground) ...

10 years, 7 months ago (2010-05-10 22:46:52 UTC) #2

adlr

10 years, 7 months ago (2010-05-10 23:13:06 UTC) #3

Thanks. fixed and submitted.

On Mon, May 10, 2010 at 3:46 PM, <cmasone@chromium.org> wrote:

> lgtm w/nits
>
>
> http://codereview.chromium.org/2055008/diff/1/3
> File src/platform/update_engine/main.cc (right):
>
> http://codereview.chromium.org/2055008/diff/1/3#newcode22
> src/platform/update_engine/main.cc:22: DEFINE_bool(forground, false,
> foreground
>
> http://codereview.chromium.org/2055008/diff/1/3#newcode97
> src/platform/update_engine/main.cc:97: if (!FLAGS_forground)
> foreground
>
>
> http://codereview.chromium.org/2055008/show
>

Expand Messages | Collapse Messages