Issue 2054007: ARM: Optimize shifts by constant integers, especially...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2054007: ARM: Optimize shifts by constant integers, especially... (Closed)

Created:
10 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Optimize shifts by constant integers, especially shifts by zero or arithmetic shifts. Updated to also eliminate ASR followed by LSL as per part two of http://codereview.chromium.org/1987008/show Committed: http://code.google.com/p/v8/source/detail?r=4641

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+41 lines, -19 lines)			Patch
	M	src/arm/codegen-arm.cc	View	1	1 chunk	+41 lines, -19 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 7 months ago (2010-05-11 07:57:11 UTC) #2

LGTM

http://codereview.chromium.org/2054007/diff/5001/1003
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2054007/diff/5001/1003#newcode1179
src/arm/codegen-arm.cc:1179: if (shift_value < 2) {
With the test above this is shift_value == 1.

Expand Messages | Collapse Messages