Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: base/stats_table_unittest.cc

Issue 2054003: Revert StatsTableTest.MultipleThreads change which is failing tsan. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/stats_table_unittest.cc
diff --git a/base/stats_table_unittest.cc b/base/stats_table_unittest.cc
index bb7dacdf07e6f3f168a214e8eaea6cd0595f7b79..079335121d0e9224b909786c2a61ec0ca769bdad 100644
--- a/base/stats_table_unittest.cc
+++ b/base/stats_table_unittest.cc
@@ -109,8 +109,9 @@ void StatsTableThread::Run() {
// Create a few threads and have them poke on their counters.
// Currently disabled. See bug report below:
-// Flaky, http://crbug.com/10611
-TEST_F(StatsTableTest, FLAKY_MultipleThreads) {
+// TODO(maruel): http://crbug.com/10611
+TEST_F(StatsTableTest, MultipleThreads) {
+#if 0
// Create a stats table.
const std::string kTableName = "MultipleThreadStatTable";
const int kMaxThreads = 20;
@@ -163,6 +164,7 @@ TEST_F(StatsTableTest, FLAKY_MultipleThreads) {
EXPECT_EQ(0, table.CountThreadsRegistered());
DeleteShmem(kTableName);
+#endif
}
const std::string kMPTableName = "MultipleProcessStatTable";
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698