Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 20535: Include a better sample JSON dataset in traceline. (Closed)

Created:
11 years, 10 months ago by Dean McNamee
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Include a better sample JSON dataset in traceline. The previous startup-off2.json didn't have stack traces. It was also quite large, it was unfiltered and contained every single system call event. Include a program to filter a JSON data set to only include events that took a worthwhile amount of time. This greatly reduces the size of the JSON data. A new filtered JSON dataset startup-release.json is included, much smaller and with stack traces. Added an ignore for checkdeps on traceline/.

Patch Set 1 #

Patch Set 2 : Delete the old dataset. #

Patch Set 3 : Add a skipdep rule. #

Patch Set 4 : DEPS #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -1 line) Patch
A tools/DEPS View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/traceline/svgui/README View 1 chunk +1 line, -1 line 0 comments Download
A tools/traceline/svgui/startup-release.json View 1 chunk +178 lines, -0 lines 0 comments Download
A tools/traceline/traceline/scripts/filter_short.py View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Dean McNamee
I probably should have done this originally, but I didn't think too much about the ...
11 years, 10 months ago (2009-02-20 12:13:55 UTC) #1
Dean McNamee
Btw, this deletes the old startup-off2.json, but Rietveld isn't showing that. On 2009/02/20 12:13:55, Dean ...
11 years, 10 months ago (2009-02-20 12:15:26 UTC) #2
M-A Ruel
11 years, 10 months ago (2009-02-20 14:56:57 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698