Introduced a platform independent version of strchr, as the return value is c...

Introduced a platform independent version of strchr, as the return value is const on Windows.

This fixes building of D8 on Windows.

Mac OS and FreeBSD changes have not been tested.

Committed: http://code.google.com/p/v8/source/detail?r=1326

[Christian Plesner Hansen, 2009-02-20 11:20:09]

Lgtm, with comment.

http://codereview.chromium.org/20534/diff/1/7
File src/platform.h (right):

http://codereview.chromium.org/20534/diff/1/7#newcode222
Line 222: static char* StrChr(const char* str, int c);
Consider making the argument non-const.  I've been bitten by passing a string
that shouldn't be modified into strchr and then modifying the result -- the
error on windows was what alerted me to it.

[Søren Thygesen Gjesse, 2009-02-20 11:31:07]

http://codereview.chromium.org/20534/diff/1/7
File src/platform.h (right):

http://codereview.chromium.org/20534/diff/1/7#newcode222
Line 222: static char* StrChr(const char* str, int c);
Good point removed const from the argument.

On 2009/02/20 11:20:09, Christian Plesner Hansen wrote:
> Consider making the argument non-const.  I've been bitten by passing a string
> that shouldn't be modified into strchr and then modifying the result -- the
> error on windows was what alerted me to it.