Issue 2051001: Fixed issue 697 allowing Object.create to be called with a function....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2051001: Fixed issue 697 allowing Object.create to be called with a function.... (Closed)

Created:
10 years, 7 months ago by Rico

Modified:
9 years, 6 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fixed issue 697 allowing Object.create to be called with a function. This change allows Object.create to take a function as input in the proto argument. The spec says that Type(O) for the proto argument should be true but our IS_OBJECT does not check for this. I will make a IS_SPEC_OBJECT in macros.py and refactor v8natives in another CL. Committed: http://code.google.com/p/v8/source/detail?r=4622

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -1 line)			Patch
	M	src/v8natives.js	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
	A	test/mjsunit/regress/regress-697.js	View		1 chunk	+34 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/2051001/diff/4001/5001 File src/v8natives.js (right): http://codereview.chromium.org/2051001/diff/4001/5001#newcode663 src/v8natives.js:663: // IS_OBJECT will return true on null covering ...

10 years, 7 months ago (2010-05-07 20:26:37 UTC) #3

Rico

10 years, 7 months ago (2010-05-09 12:06:33 UTC) #4

http://codereview.chromium.org/2051001/diff/4001/5001
File src/v8natives.js (right):

http://codereview.chromium.org/2051001/diff/4001/5001#newcode663
src/v8natives.js:663: // IS_OBJECT will return true on null covering this case.
On 2010/05/07 20:26:37, Erik Corry wrote:
> this -> that

Done.

Expand Messages | Collapse Messages