Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4098)

Unified Diff: build/build-bisect.py

Issue 205022: build-bisect: minor usability tweaks (Closed)
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/build-bisect.py
diff --git a/build/build-bisect.py b/build/build-bisect.py
index 6eddf6dc6f91b7295a3903d793c37b0a78b39cc2..29bbfd49db061d5cd6175d4f1b859ec438da16e9 100755
--- a/build/build-bisect.py
+++ b/build/build-bisect.py
@@ -112,14 +112,16 @@ def TryRevision(rev):
os.system("unzip -q %s" % BUILD_ZIP_NAME)
# Tell the system to open the app.
- print 'Running %s/%s/%s' % (os.getcwd(), BUILD_DIR_NAME, BUILD_EXE_NAME)
+ flags = '--user-data-dir=profile'
+ print 'Running %s/%s/%s %s' % (os.getcwd(), BUILD_DIR_NAME, BUILD_EXE_NAME,
+ flags)
if BUILD_ARCHIVE_TYPE in ('linux', 'linux-64'):
- os.system("%s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME))
+ os.system("%s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags))
elif BUILD_ARCHIVE_TYPE in ('mac'):
- os.system("open %s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME))
+ os.system("open %s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags))
elif BUILD_ARCHIVE_TYPE in ('xp'):
# TODO(mmoss) Does Windows need 'start' or something?
- os.system("%s/%s" % (BUILD_DIR_NAME, BUILD_EXE_NAME))
+ os.system("%s/%s %s" % (BUILD_DIR_NAME, BUILD_EXE_NAME, flags))
os.chdir(cwd)
print 'Cleaning temp dir ...'
@@ -141,9 +143,12 @@ def main():
usage = ('%prog [options]\n'
'Perform binary search on the snapshot builds.')
parser = optparse.OptionParser(usage=usage)
+ # Strangely, the default help output doesn't include the choice list.
+ choices = ['mac', 'xp', 'linux', 'linux-64']
parser.add_option('-a', '--archive',
- choices = ['mac', 'xp', 'linux', 'linux-64'],
- help = 'The buildbot archive to bisect.')
+ choices = choices,
+ help = 'The buildbot archive to bisect [%s].' %
+ '|'.join(choices))
parser.add_option('-b', '--bad', type = 'int',
help = 'The bad revision to bisect to.')
parser.add_option('-g', '--good', type = 'int',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698