Issue 205016: Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205016: Avoid spurious errors about NSColor-CGColor and NSSize-CGSize conversions (Closed)

Created:
11 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Paul Godavari, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Avoid spurious errors about NSColor*-CGColor* and NSSize-CGSize conversions The SDK has gotten stupider in 10.6, and has conspired with the compiler, which now thinks that when the receiver is held in a scoped_nsobject, NSColor and NSSize arguments should be converted to their CG cousins. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26348

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -10 lines)			Patch
M	chrome/browser/cocoa/browser_window_controller.mm	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/bubble_view.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/download_item_cell.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/gradient_button_cell.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/cocoa/tab_cell.mm	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LG