Issue 205010: Reverting 26219.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 205010: Reverting 26219. (Closed)

Created:
11 years, 3 months ago by rohitrao (ping after 24h)

Modified:
9 years, 7 months ago

Reviewers:
rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, pam+watch_chromium.org, Ben Goodger (Google), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

[Mac] Restore focus to the previously focused view when dismissing the find bar. If a result was found, restore focus to the tab contents. This allows for keyboard navigation using the find bar. Now with fix for valgrind failure. This CL reverts 26219, which in turn reverted 26214. BUG=http://crbug.com/12657 BUG=http://crbug.com/21374 TEST=See test case in bug 21374 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26231

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+198 lines, -1 line)			Patch
MM	chrome/browser/cocoa/find_bar_bridge.mm	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/cocoa/find_bar_cocoa_controller.h	View	1	3 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/find_bar_cocoa_controller.mm	View	1	4 chunks	+23 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/focus_tracker.h	View	1	1 chunk	+28 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/focus_tracker.mm	View	1	1 chunk	+46 lines, -0 lines	0 comments	Download
A	chrome/browser/cocoa/focus_tracker_unittest.mm	View	1	1 chunk	+92 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1	2 chunks	+3 lines, -0 lines	0 comments	Download