Issue 2050013: Added a death test for the pure virtual function call....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2050013: Added a death test for the pure virtual function call.... (Closed)

Created:
10 years, 7 months ago by hansl_g

Modified:
9 years, 7 months ago

Reviewers:
Sigurður Ásgeirsson

CC:
chromium-reviews

Base URL:
http://google-breakpad.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Added a death test for the pure virtual function call. Added a test for the minidump generated by a pure virtual function call. Changed the pure virtual function call handler so that it creates a minidump with Exception info and a stack. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=597

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+174 lines, -8 lines)			Patch
M	src/client/windows/handler/exception_handler.cc	View	1 2	3 chunks	+25 lines, -2 lines	0 comments	Download
M	src/client/windows/unittests/exception_handler_death_test.cc	View	1	4 chunks	+37 lines, -3 lines	1 comment	Download
M	src/client/windows/unittests/exception_handler_test.cc	View	1	5 chunks	+112 lines, -3 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sigurður Ásgeirsson

10 years, 7 months ago (2010-05-13 20:57:10 UTC) #2

lgtm

http://codereview.chromium.org/2050013/diff/10001/11002
File src/client/windows/unittests/exception_handler_death_test.cc (right):

http://codereview.chromium.org/2050013/diff/10001/11002#newcode188
src/client/windows/unittests/exception_handler_death_test.cc:188:
reinterpret_cast<PureVirtualCallBase*>(this)->PureFunction();
Really? How weird.

Expand Messages | Collapse Messages