Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(753)

Issue 2050007: Add listbreakpoints command to protocol (Closed)

Created:
10 years, 7 months ago by Peter Rybin
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add listbreakpoints command to protocol Committed: http://code.google.com/p/v8/source/detail?r=4656

Patch Set 1 #

Total comments: 2

Patch Set 2 : follow codereview #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -2 lines) Patch
M src/d8.js View 6 chunks +55 lines, -2 lines 0 comments Download
M src/debug-debugger.js View 1 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Peter Rybin
Hi Soren I need to synchronize breakpoints between Eclipse IDE and V8 VM (both sides ...
10 years, 7 months ago (2010-05-11 14:27:11 UTC) #1
Søren Thygesen Gjesse
Please add a 'UI' for this in the D8 shell. http://codereview.chromium.org/2050007/diff/1/2 File src/debug-debugger.js (right): http://codereview.chromium.org/2050007/diff/1/2#newcode1587 ...
10 years, 7 months ago (2010-05-11 14:50:11 UTC) #2
Peter Rybin
UI added. http://codereview.chromium.org/2050007/diff/1/2 File src/debug-debugger.js (right): http://codereview.chromium.org/2050007/diff/1/2#newcode1587 src/debug-debugger.js:1587: var array = []; On 2010/05/11 14:50:11, ...
10 years, 7 months ago (2010-05-13 18:36:04 UTC) #3
Søren Thygesen Gjesse
LGTM I will look into the function break points, but I think that a function ...
10 years, 7 months ago (2010-05-14 14:06:15 UTC) #4
Peter Rybin
10 years, 7 months ago (2010-05-14 15:06:06 UTC) #5
On 2010/05/14 14:06:15, Søren Gjesse wrote:
> LGTM
> 
> I will look into the function break points, but I think that a function
created
> from eval might not be converted to a script break point.

I simply tried this:

var FunctionFromEval = eval("(function TTTT() { return 5; })");

then I did:
break FunctionFromEval

I got script breakpoint

Powered by Google App Engine
This is Rietveld 408576698