Fixes bug with v8::StackTrace for non-zero script line offsets...

test/cctest/test-api.cc

 // Copyright 2007-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 9616 matching lines @@
                     stackTrace->GetFrame(2));
     // The last frame is an anonymous function that has the initial call.
     checkStackFrame(origin, "", 8, 7, false, false,
                     stackTrace->GetFrame(3));
 
     CHECK(stackTrace->AsArray()->IsArray());
   } else if (testGroup == kDetailedTest) {
     v8::Handle<v8::StackTrace> stackTrace =
         v8::StackTrace::CurrentStackTrace(10, v8::StackTrace::kDetailed);
     CHECK_EQ(4, stackTrace->GetFrameCount());
-    checkStackFrame(origin, "bat", 2, 1, false, false,
+    checkStackFrame(origin, "bat", 4, 22, false, false,
                     stackTrace->GetFrame(0));
-    checkStackFrame(origin, "baz", 5, 3, false, true,
+    checkStackFrame(origin, "baz", 8, 3, false, true,
                     stackTrace->GetFrame(1));
     checkStackFrame(NULL, "", 1, 1, true, false,
                     stackTrace->GetFrame(2));
     // The last frame is an anonymous function that has the initial call to foo.
-    checkStackFrame(origin, "", 7, 1, false, false,
+    checkStackFrame(origin, "", 10, 1, false, false,
                     stackTrace->GetFrame(3));
 
     CHECK(stackTrace->AsArray()->IsArray());
   }
   return v8::Undefined();
 }
 
 
 // Tests the C++ StackTrace API.
 THREADED_TEST(CaptureStackTrace) {
@@ skipping 16 matching lines @@
     "}\n"
     "var x;eval('new foo();');";
   v8::Handle<v8::String> overview_src = v8::String::New(overview_source);
   v8::Handle<Value> overview_result =
       v8::Script::New(overview_src, origin)->Run();
   ASSERT(!overview_result.IsEmpty());
   ASSERT(overview_result->IsObject());
 
   // Test getting DETAILED information.
   const char *detailed_source =
-    "function bat() {\n"
-    "AnalyzeStackInNativeCode(2);\n"
+    "function bat() {AnalyzeStackInNativeCode(2);\n"
     "}\n"
+    "\n"
     "function baz() {\n"
     "  bat();\n"
     "}\n"
     "eval('new baz();');";
   v8::Handle<v8::String> detailed_src = v8::String::New(detailed_source);
-  v8::Handle<Value> detailed_result =
-      v8::Script::New(detailed_src, origin)->Run();
+  // Make the script using a non-zero line and column offset.
+  v8::Handle<v8::Integer> line_offset = v8::Integer::New(3);
+  v8::Handle<v8::Integer> column_offset = v8::Integer::New(5);
+  v8::ScriptOrigin detailed_origin(origin, line_offset, column_offset);
+  v8::Handle<v8::Script> detailed_script(
+      v8::Script::New(detailed_src, &detailed_origin));
+  v8::Handle<Value> detailed_result = detailed_script->Run();
   ASSERT(!detailed_result.IsEmpty());
   ASSERT(detailed_result->IsObject());
 }
 
 
 // Test that idle notification can be handled and eventually returns true.
 THREADED_TEST(IdleNotification) {
   bool rv = false;
   for (int i = 0; i < 100; i++) {
     rv = v8::V8::IdleNotification();
@@ skipping 673 matching lines @@
   const char* code =
       "(function() {"
       "  for (var i = 0; i < 2*16; i++) {"
       "    %_GetFromCache(0, 'a' + i);"
       "  };"
       "  return 'PASSED';"
       "})()";
   v8::internal::Heap::ClearJSFunctionResultCaches();
   ExpectString(code, "PASSED");
 }