Issue 2047002: Add a flag to the ARM version of new space allocation in generated code...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2047002: Add a flag to the ARM version of new space allocation in generated code... (Closed)

Created:
10 years, 7 months ago by Søren Thygesen Gjesse

Modified:
10 years, 7 months ago

Reviewers:
Vyacheslav Egorov (Chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add a flag to the ARM version of new space allocation in generated code The flag SIZE_IN_WORDS indicate that the requested size is in words and not in bytes, The default is to specify the size in bytes. Committed: http://code.google.com/p/v8/source/detail?r=4617

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+100 lines, -61 lines)			Patch
M	src/arm/builtins-arm.cc	View	1	5 chunks	+17 lines, -15 lines	0 comments	Download
M	src/arm/codegen-arm.cc	View	1	6 chunks	+24 lines, -17 lines	1 comment	Download
M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+13 lines, -0 lines	1 comment	Download
M	src/arm/macro-assembler-arm.cc	View	1 2	10 chunks	+23 lines, -17 lines	1 comment	Download
M	src/arm/stub-cache-arm.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	src/ia32/macro-assembler-ia32.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download
M	src/macro-assembler.h	View	1	1 chunk	+0 lines, -11 lines	0 comments	Download
M	src/x64/macro-assembler-x64.h	View	1	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vyacheslav Egorov (Chromium)

10 years, 7 months ago (2010-05-07 13:18:25 UTC) #2

LGTM

http://codereview.chromium.org/2047002/diff/21001/19008
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2047002/diff/21001/19008#newcode5913
src/arm/codegen-arm.cc:5913: length + (FixedArray::kHeaderSize / kPointerSize),
FixedArray::SizeFor(length) and allocation in bytes?

http://codereview.chromium.org/2047002/diff/21001/19009
File src/arm/macro-assembler-arm.cc (right):

http://codereview.chromium.org/2047002/diff/21001/19009#newcode963
src/arm/macro-assembler-arm.cc:963: add(result, result, Operand(object_size));
May be add some ASSERTion on object_size alignment?

http://codereview.chromium.org/2047002/diff/21001/19005
File src/arm/macro-assembler-arm.h (right):

http://codereview.chromium.org/2047002/diff/21001/19005#newcode64
src/arm/macro-assembler-arm.h:64: SIZE_IN_WORDS = 1 << 2
Comment about SIZE_IN_WORDS meaning for the sake of uniformity?

Expand Messages | Collapse Messages