Prevent chrome from launching with a chromehtml: argument...

chrome/app/chrome_dll_main.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(port): the ifdefs in here are a first step towards trying to determine
 // the correct abstraction for all the OS functionality required at this
 // stage of process initialization. It should not be taken as a final
 // abstraction.
 
 #include "build/build_config.h"
 
 #if defined(OS_WIN)
+#include <algorithm>
 #include <atlbase.h>
 #include <atlapp.h>
 #include <malloc.h>
 #include <new.h>
 #endif
 
 #if defined(OS_LINUX)
 #include <gtk/gtk.h>
 #endif
 
@@ skipping 86 matching lines @@
   // Get the breakpad pointer from chrome.exe
   typedef void (__stdcall *DumpProcessFunction)();
   DumpProcessFunction DumpProcess = reinterpret_cast<DumpProcessFunction>(
       ::GetProcAddress(::GetModuleHandle(L"chrome.exe"), "DumpProcess"));
   if (DumpProcess)
     DumpProcess();
 }
 
 #pragma optimize("", on)
 
+// Early versions of Chrome incorrectly registered a chromehtml: URL handler.
+// Later versions fixed the registration but in some cases (e.g. Vista and non-
+// admin installs) the fix could not be applied.  This prevents Chrome to be
+// launched with the incorrect format.
+// CORRECT: <broser.exe> -- "chromehtml:<url>"
+// INVALID: <broser.exe> "chromehtml:<url>"
+bool IncorrectChromeHtmlArguments(const std::wstring& command_line) {
+  const wchar_t kChromeHtml[] = L"-- \"chromehtml:";
+  const wchar_t kOffset = 5;  // Where chromehtml: starts in above
+  std::wstring command_line_lower = command_line;
+
+  // We are only searching for ASCII characters so this is OK.
+  StringToLowerASCII(&command_line_lower);
+
+  std::wstring::size_type pos = command_line_lower.find(
+      kChromeHtml + kOffset);
+
+  if (pos == std::wstring::npos)
+    return false;
+
+  // The browser is being launched with chromehtml: somewhere on the command
+  // line.  We will not launch unless it's preceded by the -- switch terminator.
+  if (pos >= kOffset) {
+    if (equal(kChromeHtml, kChromeHtml + arraysize(kChromeHtml) - 1, 
+        command_line_lower.begin() + pos - kOffset)) {
+      return false;
+    }
+  }
+
+  return true;
+}
+
 #endif  // OS_WIN
 
 // Register the invalid param handler and pure call handler to be able to
 // notify breakpad when it happens.
 void RegisterInvalidParamHandler() {
 #if defined(OS_WIN)
   _set_invalid_parameter_handler(InvalidParameter);
   _set_purecall_handler(PureCall);
   // Gather allocation failure.
   _set_new_handler(&OnNoMemory);
@@ skipping 91 matching lines @@
 #endif
 
   // Initialize the command line.
 #if defined(OS_WIN)
   CommandLine::Init(0, NULL);
 #else
   CommandLine::Init(argc, argv);
 #endif
   const CommandLine& parsed_command_line = *CommandLine::ForCurrentProcess();
 
+#if defined(OS_WIN)
+   // Must do this before any other usage of command line!
+  if (::IncorrectChromeHtmlArguments(parsed_command_line.command_line_string()))
+    return 1;
+#endif
+
   SetupCRT(parsed_command_line);
 
   // Initialize the Chrome path provider.
   chrome::RegisterPathProvider();
 
   // Initialize the Stats Counters table.  With this initialized,
   // the StatsViewer can be utilized to read counters outside of
   // Chrome.  These lines can be commented out to effectively turn
   // counters 'off'.  The table is created and exists for the life
   // of the process.  It is not cleaned up.
@@ skipping 103 matching lines @@
 
   _Module.Term();
 #endif
 
   logging::CleanupChromeLogging();
 
   return rv;
 }