Issue 2046002: [TFF] Coverage: Don't include any chromeos directory in the Linux code coverage analysis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2046002: [TFF] Coverage: Don't include any chromeos directory in the Linux code coverage analysis. (Closed)

Created:
10 years, 7 months ago by James Hawkins

Modified:
9 years, 7 months ago

Reviewers:
John Grabowski

CC:
chromium-reviews

Visibility:
Public.

Description

[TFF] Coverage: Don't include any non-Linux platform directories in the Linux code coverage analysis. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46647

Patch Set 4 : Also ignore views dir. #

Patch Set 5 : No views files. #

Total comments: 2

Patch Set 6 : Update mac. #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -3 lines)			Patch
	M	build/linux/chrome_linux.croc	View	1 2 3 4	2 chunks	+9 lines, -1 line	0 comments	Download
	M	build/mac/chrome_mac.croc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

LGTM, but please add comments to the top of the file clarifying that we will ...

10 years, 7 months ago (2010-05-07 00:19:06 UTC) #2

James Hawkins

On 2010/05/07 00:19:06, John Grabowski wrote: > LGTM, but please add comments to the top ...

10 years, 7 months ago (2010-05-07 00:22:16 UTC) #3

John Grabowski

Still LGTM http://codereview.chromium.org/2046002/diff/10001/11001 File build/linux/chrome_linux.croc (right): http://codereview.chromium.org/2046002/diff/10001/11001#newcode33 build/linux/chrome_linux.croc:33: 'regexp' : '.*/(chromeos|views)/', Update to exclude "views" ...

10 years, 7 months ago (2010-05-07 00:55:17 UTC) #4

James Hawkins

10 years, 7 months ago (2010-05-07 00:59:50 UTC) #5

http://codereview.chromium.org/2046002/diff/10001/11001
File build/linux/chrome_linux.croc (right):

http://codereview.chromium.org/2046002/diff/10001/11001#newcode33
build/linux/chrome_linux.croc:33: 'regexp' : '.*/(chromeos|views)/',
On 2010/05/07 00:55:17, John Grabowski wrote:
> Update to exclude "views" on Mac as well please.
> 

Done.