Chromium Code Reviews

Issue 20457: Limit how many places we generate code to flush the same actions. This gives... (Closed)

Created:
11 years, 10 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Limit how many places we generate code to flush the same actions. This gives a 13% code size reduction in the php regexp with no discernable performance loss. Committed: http://code.google.com/p/v8/source/detail?r=1309

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Stats (+30 lines, -14 lines)
M src/jsregexp.h View 4 chunks +4 lines, -0 lines 1 comment
M src/jsregexp.cc View 8 chunks +26 lines, -14 lines 0 comments

Messages

Total messages: 2 (0 generated)
Erik Corry
11 years, 10 months ago (2009-02-18 14:41:10 UTC) #1
Lasse Reichstein
11 years, 10 months ago (2009-02-18 15:29:05 UTC) #2
LGTM

http://codereview.chromium.org/20457/diff/1/2
File src/jsregexp.h (right):

http://codereview.chromium.org/20457/diff/1/2#newcode1179
Line 1179: flush_budget_(100),
Have other initial values of flush_budget been tried? 
How would lowering it to, say, 10 affect performance.

Powered by Google App Engine