Refactored command-line options handling in tick processor scripts

tools/windows-tick-processor.py

 #!/usr/bin/env python
 #
 # Copyright 2008 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 20 matching lines @@
 # Usage: process-ticks.py <binary> <logfile>
 #
 # Where <binary> is the binary program name (eg, v8_shell.exe) and
 # <logfile> is the log file name (eg, v8.log).
 #
 # This tick processor expects to find a map file for the binary named
 # binary.map if the binary is named binary.exe. The tick processor
 # only works for statically linked executables - no information about
 # shared libraries is logged from v8 on Windows.
 
-import os, re, sys, tickprocessor, getopt
+import os, re, sys, tickprocessor
 
 class WindowsTickProcessor(tickprocessor.TickProcessor):
 
   def Unmangle(self, name):
     """Performs very simple unmangling of C++ names.
 
     Does not handle arguments and template arguments. The mangled names have
     the form:
 
        ?LookupInDescriptor@JSObject@internal@v8@@...arguments info...
@@ skipping 48 matching lines @@
           self.cpp_entries.Insert(addr, tickprocessor.CodeEntry(addr, name));
       i = min_addr
       # Mark the pages for which there are functions in the map file.
       while i < max_addr:
         page = i >> 12
         self.vm_extent[page] = 1
         i += 4096
     finally:
       map_file.close()
 
-def Usage():
-  print("Usage: windows-tick-processor.py binary logfile-name");
-  sys.exit(2)
+
+class WindowsCmdLineProcessor(tickprocessor.CmdLineProcessor):
+
+  def __init__(self):
+    super(WindowsCmdLineProcessor, self).__init__()
+    self.binary_file = None
+
+  def GetRequiredArgsNames(self):
+    return 'binary log_file'
+
+  def ProcessRequiredArgs(self, args):
+    if len(args) != 2:
+      self.PrintUsageAndExit()
+    else:
+      self.binary_file = args[0]
+      self.log_file = args[1]
+
 
 def Main():
-  # parse command line options
-  ignore_unknown = False
-  state = None;
-  try:
-    opts, args = getopt.getopt(sys.argv[1:], "jgco", ["js", "gc", "compiler", "other", "ignore-unknown"])
-  except getopt.GetoptError:
-    usage()
-  # process options.
-  for key, value in opts:
-    if key in ("-j", "--js"):
-      state = 0
-    if key in ("-g", "--gc"):
-      state = 1
-    if key in ("-c", "--compiler"):
-      state = 2
-    if key in ("-o", "--other"):
-      state = 3
-    if key in ("--ignore-unknown"):
-      ignore_unknown = True
-  # do the processing.
-  if len(args) != 2:
-      Usage();
+  cmdline_processor = WindowsCmdLineProcessor()
+  cmdline_processor.ProcessArguments()
   tickprocessor = WindowsTickProcessor()
-  tickprocessor.ParseMapFile(args[0])
-  tickprocessor.ProcessLogfile(args[1], state, ignore_unknown)
+  tickprocessor.ParseMapFile(cmdline_processor.binary_file)
+  cmdline_processor.RunLogfileProcessing(tickprocessor)
   tickprocessor.PrintResults()
 
 if __name__ == '__main__':
   Main()