Refactored command-line options handling in tick processor scripts

tools/linux-tick-processor.py

 #!/usr/bin/env python
 #
 # Copyright 2008 the V8 project authors. All rights reserved.
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 #       notice, this list of conditions and the following disclaimer.
 #     * Redistributions in binary form must reproduce the above
@@ skipping 12 matching lines @@
 # SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
 # LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
 # DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
 # THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
 # (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
 # OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 
 # Usage: process-ticks.py <logfile>
 # Where <logfile> is the log file name (eg, v8.log).
 
-import subprocess, re, sys, tickprocessor, getopt
+import subprocess, re, sys, tickprocessor
 
 class LinuxTickProcessor(tickprocessor.TickProcessor):
 
   def ParseVMSymbols(self, filename, start, end):
     """Extract symbols and add them to the cpp entries."""
     # Extra both dynamic and non-dynamic symbols.
     command = 'nm -C -n "%s"; nm -C -n -D "%s"' % (filename, filename)
     process = subprocess.Popen(command, shell=True,
                                stdout=subprocess.PIPE,
                                stderr=subprocess.STDOUT)
     pipe = process.stdout
     try:
       for line in pipe:
         row = re.match('^([0-9a-fA-F]{8}) . (.*)$', line)
         if row:
           addr = int(row.group(1), 16)
           if addr < start and addr < end - start:
             addr += start
           self.cpp_entries.Insert(addr, tickprocessor.CodeEntry(addr, row.group(2)))
     finally:
       pipe.close()
 
 
-def Usage():
-  print("Usage: linux-tick-processor.py --{js,gc,compiler,other}  logfile-name");
-  sys.exit(2)
+class LinuxCmdLineProcessor(tickprocessor.CmdLineProcessor):
+
+  def GetRequiredArgsNames(self):
+    return 'log_file'
+
+  def ProcessRequiredArgs(self, args):
+    if len(args) != 1:
+      self.PrintUsageAndExit()
+    else:
+      self.log_file = args[0]
+
 
 def Main():
-  # parse command line options
-  ignore_unknown = False
-  state = None;
-  try:
-    opts, args = getopt.getopt(sys.argv[1:], "jgco", ["js", "gc", "compiler", "other", "ignore-unknown"])
-  except getopt.GetoptError:
-    usage()
-  # process options.
-  for key, value in opts:
-    if key in ("-j", "--js"):
-      state = 0
-    if key in ("-g", "--gc"):
-      state = 1
-    if key in ("-c", "--compiler"):
-      state = 2
-    if key in ("-o", "--other"):
-      state = 3
-    if key in ("--ignore-unknown"):
-      ignore_unknown = True
-  # do the processing.
-  if len(args) != 1:
-      Usage();
+  cmdline_processor = LinuxCmdLineProcessor()
+  cmdline_processor.ProcessArguments()
   tick_processor = LinuxTickProcessor()
-  tick_processor.ProcessLogfile(args[0], state, ignore_unknown)
+  cmdline_processor.RunLogfileProcessing(tick_processor)
   tick_processor.PrintResults()
 
+
 if __name__ == '__main__':
   Main()