Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Unified Diff: src/codegen-arm.cc

Issue 20419: Optimize loads from variables that might be shadowed by variables... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/codegen-ia32.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codegen-arm.cc
===================================================================
--- src/codegen-arm.cc (revision 1289)
+++ src/codegen-arm.cc (working copy)
@@ -1105,7 +1105,7 @@
if (slot != NULL && slot->type() == Slot::LOOKUP) {
// Variables with a "LOOKUP" slot were introduced as non-locals
// during variable resolution and must have mode DYNAMIC.
- ASSERT(var->mode() == Variable::DYNAMIC);
+ ASSERT(var->is_dynamic());
// For now, just do a runtime call.
frame_->Push(cp);
__ mov(r0, Operand(var->name()));
@@ -1983,7 +1983,7 @@
void CodeGenerator::LoadFromSlot(Slot* slot, TypeofState typeof_state) {
if (slot->type() == Slot::LOOKUP) {
- ASSERT(slot->var()->mode() == Variable::DYNAMIC);
+ ASSERT(slot->var()->is_dynamic());
// For now, just do a runtime call.
frame_->Push(cp);
@@ -2000,7 +2000,7 @@
} else {
// Note: We would like to keep the assert below, but it fires because of
// some nasty code in LoadTypeofExpression() which should be removed...
- // ASSERT(slot->var()->mode() != Variable::DYNAMIC);
+ // ASSERT(!slot->var()->is_dynamic());
// Special handling for locals allocated in registers.
__ ldr(r0, SlotOperand(slot, r2));
@@ -3348,7 +3348,7 @@
Slot* slot = expression_->AsVariableProxy()->AsVariable()->slot();
ASSERT(slot != NULL);
if (slot->type() == Slot::LOOKUP) {
- ASSERT(slot->var()->mode() == Variable::DYNAMIC);
+ ASSERT(slot->var()->is_dynamic());
// For now, just do a runtime call.
frame->Push(cp);
@@ -3380,7 +3380,7 @@
frame->Push(r0);
} else {
- ASSERT(slot->var()->mode() != Variable::DYNAMIC);
+ ASSERT(!slot->var()->is_dynamic());
Label exit;
if (init_state == CONST_INIT) {
« no previous file with comments | « no previous file | src/codegen-ia32.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698