Issue 2041010: ARM: Fix jumptargets to actually merge virtual frames....

Issue 2041010: ARM: Fix jumptargets to actually merge virtual frames.... (Closed)

Created:
10 years, 7 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

ARM: Fix jumptargets to actually merge virtual frames. Make use of the new functionality to make ++ and -- non-spilled operations. Committed: http://code.google.com/p/v8/source/detail?r=4644

Patch Set 1 #

Total comments: 6

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, -30 lines)			Patch
M	src/arm/codegen-arm.cc	View	4 chunks	+29 lines, -26 lines	2 comments	Download
M	src/arm/virtual-frame-arm.h	View	3 chunks	+13 lines, -2 lines	4 comments	Download
M	src/arm/virtual-frame-arm.cc	View	3 chunks	+43 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/2041010/diff/1/2 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/2041010/diff/1/2#newcode5044 src/arm/codegen-arm.cc:5044: __ Move(tos, r0); Perhaps make a spill scope ...

10 years, 7 months ago (2010-05-11 13:46:12 UTC) #2

Erik Corry

10 years, 7 months ago (2010-05-12 09:00:32 UTC) #3

http://codereview.chromium.org/2041010/diff/1/2
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/2041010/diff/1/2#newcode5044
src/arm/codegen-arm.cc:5044: __ Move(tos, r0);
On 2010/05/11 13:46:12, Søren Gjesse wrote:
> Perhaps make a spill scope from SpillAll above to here.

Done.

http://codereview.chromium.org/2041010/diff/1/4
File src/arm/virtual-frame-arm.h (right):

http://codereview.chromium.org/2041010/diff/1/4#newcode233
src/arm/virtual-frame-arm.h:233: ASSERT(adjusted_index >= 0);
On 2010/05/11 13:46:12, Søren Gjesse wrote:
> You don't want to spill to the point where this always is possible?

I think I want to keep that explicit since we want to try to avoid spilling.

http://codereview.chromium.org/2041010/diff/1/4#newcode363
src/arm/virtual-frame-arm.h:363: void OverwriteStackPosition(Register reg, int
this_far_down);
On 2010/05/11 13:46:12, Søren Gjesse wrote:
> Why is this not called SetElementAt?

Done.

Expand Messages | Collapse Messages