Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 204042: Add a suppression for a known V8 leak. (Closed)

Created:
11 years, 3 months ago by brettw
Modified:
9 years, 7 months ago
Reviewers:
Vitaly Repeshko, dank
CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, Timur Iskhodzhanov, stuartmorgan, pam+watch_chromium.org
Visibility:
Public.

Description

Add a suppression for a known V8 leak. TEST=none BUG=22021 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26367

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR
11 years, 3 months ago (2009-09-16 18:21:18 UTC) #1
Vitaly Repeshko
LGTM
11 years, 3 months ago (2009-09-16 18:25:17 UTC) #2
dank
11 years, 3 months ago (2009-09-16 18:37:31 UTC) #3
It's missing the line

Memcheck:Leak

I'll fix for you.  I will also update valgrind on the bots so
it provides that line in the sample suppression.

Powered by Google App Engine
This is Rietveld 408576698