Issue 204039: Fix GC bug and ARM simulator timeout

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204039: Fix GC bug and ARM simulator timeout (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Christian Plesner Hansen

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Fix GC bug and ARM simulator timeout. In the Runtime_DebugGetPropertyDetails the raw object pointers from a LookupResult could be used after a GC might have happened. Fixed the bug and restructured the code to make it less likely for changes to the code to re-introduce the bug. Skipped a long running test from the ARM simulator in debug mode (and renamed the test). Committed: http://code.google.com/p/v8/source/detail?r=2902

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -157 lines)			Patch
M	src/runtime.cc	View	1	1 chunk	+35 lines, -39 lines	0 comments	Download
A +	test/mjsunit/array-constructor.js	View		0 chunks	+-1 lines, --1 lines	0 comments	Download
D	test/mjsunit/array-construtor.js	View		1 chunk	+0 lines, -119 lines	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Lgtm

Expand Messages | Collapse Messages