Issue 204026: Unified the color definitions for the dividers so that extension shelf is usi...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 204026: Unified the color definitions for the dividers so that extension shelf is usi... (Closed)

Created:
11 years, 3 months ago by Finnur

Modified:
9 years, 6 months ago

Reviewers:
Erik does not do reviews

CC:
chromium-reviews_googlegroups.com, pam+watch_chromium.org, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Unified the color definitions for the dividers so that extension shelf is using the same values as the bookmark bar. The bookmark bar dividers looked much better against very light background than the extension shelf ones did. BUG=18452 TEST=The dividers should look like the bookmark ones and should not look bad against very light colored backgrounds. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=26274

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
M	chrome/browser/views/bookmark_bar_view.cc	View		3 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/browser/views/detachable_toolbar_view.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/detachable_toolbar_view.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/views/extensions/extension_shelf.cc	View	1	2 chunks	+2 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages