Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2038015: Moved demos.gyp from windows dependency to all platforms. Excluded gpu_demo_f... (Closed)

Created:
10 years, 7 months ago by alokp
Modified:
9 years, 6 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Moved demos.gyp from windows dependency to all platforms. Excluded gpu_demo_framework_pepper from being included with wildcard demos.gyp:*. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=47270

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M build/all.gyp View 2 chunks +1 line, -1 line 0 comments Download
M gpu/demos/demos.gyp View 1 chunk +5 lines, -0 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
alokp
10 years, 7 months ago (2010-05-13 17:26:13 UTC) #1
apatrick
http://codereview.chromium.org/2038015/diff/1/3 File gpu/demos/demos.gyp (right): http://codereview.chromium.org/2038015/diff/1/3#newcode63 gpu/demos/demos.gyp:63: 'suppress_wildcard': 1, I defer to someone who knows more ...
10 years, 7 months ago (2010-05-13 17:34:04 UTC) #2
Mark Mentovai
10 years, 7 months ago (2010-05-13 17:59:21 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698