Change socket pool max from 100 to 1000000

Change socket pool max from 100 to 1000000
This will effectively disable the socket limit, which is known to be buggy and can cause the IO thread to enter into an infinite loop.
BUG=42267
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46641

[willchan no longer on Chromium, 2010-05-07 00:18:19]

LGTM

On Thu, May 6, 2010 at 5:14 PM,  <laforge@chromium.org> wrote:
> Reviewers: willchan,
>
> Description:
> Change socket pool max from 100 to 1000000
>
> Please review this at http://codereview.chromium.org/2038005/show
>
> SVN Base: svn://svn.chromium.org/chrome/branches/375/src/
>
> Affected files:
>  M     net/http/http_network_session.cc
>
>
> Index: net/http/http_network_session.cc
> ===================================================================
> --- net/http/http_network_session.cc    (revision 46586)
> +++ net/http/http_network_session.cc    (working copy)
> @@ -12,7 +12,7 @@
>  namespace net {
>
>  // static
> -int HttpNetworkSession::max_sockets_ = 100;
> +int HttpNetworkSession::max_sockets_ = 1000000;
>
>  // static
>  int HttpNetworkSession::max_sockets_per_group_ = 6;
>
>
>

[Mark Mentovai, 2010-05-07 19:01:29]

http://codereview.chromium.org/2038005/diff/1/2
File net/http/http_network_session.cc (right):

http://codereview.chromium.org/2038005/diff/1/2#newcode15
net/http/http_network_session.cc:15: int HttpNetworkSession::max_sockets_ =
1000000;
Will, does this leave us exposed to file descriptor exhaustion?

[willchan no longer on Chromium, 2010-05-07 22:40:22]

On Fri, May 7, 2010 at 12:01 PM,  <mark@chromium.org> wrote:
>
> http://codereview.chromium.org/2038005/diff/1/2
> File net/http/http_network_session.cc (right):
>
> http://codereview.chromium.org/2038005/diff/1/2#newcode15
> net/http/http_network_session.cc:15: int
> HttpNetworkSession::max_sockets_ = 1000000;
> Will, does this leave us exposed to file descriptor exhaustion?

Theoretically, but probably not.  The limit that we've had was pretty
broken (does not count idle sockets).  If you have concerns, we can
chat about this in real-time (irc or IM or whatever), since it'd be
tiresome to explain fully over email.

>
> http://codereview.chromium.org/2038005/show
>