Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: webkit/glue/webview_delegate.h

Issue 20378: Reduce the amount of included header files. Vast change like in "Oh God! This... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/glue/webview_delegate.h
===================================================================
--- webkit/glue/webview_delegate.h (revision 9942)
+++ webkit/glue/webview_delegate.h (working copy)
@@ -26,15 +26,10 @@
#ifndef WEBKIT_GLUE_WEBVIEW_DELEGATE_H_
#define WEBKIT_GLUE_WEBVIEW_DELEGATE_H_
-#include <string>
#include <vector>
-#include "base/basictypes.h"
-#include "base/logging.h"
-#include "googleurl/src/gurl.h"
#include "webkit/glue/context_menu.h"
#include "webkit/glue/webwidget_delegate.h"
-#include "webkit/glue/window_open_disposition.h"
namespace gfx {
class Point;
@@ -657,11 +652,7 @@
return true;
}
- virtual void SetSmartInsertDeleteEnabled(bool enabled) {
- // This method is only used in test shell, which overrides this
- // method.
- NOTREACHED();
- }
+ virtual void SetSmartInsertDeleteEnabled(bool enabled);
virtual bool IsSelectTrailingWhitespaceEnabled() {
#if defined(OS_WIN)
@@ -671,11 +662,7 @@
#endif
}
- virtual void SetSelectTrailingWhitespaceEnabled(bool enabled) {
- // This method is only used in test shell, which overrides this
- // method.
- NOTREACHED();
- }
+ virtual void SetSelectTrailingWhitespaceEnabled(bool enabled);
virtual void DidBeginEditing() { }
virtual void DidChangeSelection(bool is_empty_selection) { }
@@ -711,9 +698,7 @@
// error pages. |error_name| tells the delegate what type of error page we
// want (e.g., 404 vs dns errors).
virtual GURL GetAlternateErrorPageURL(const GURL& failedURL,
- ErrorPageType error_type) {
- return GURL();
- }
+ ErrorPageType error_type);
// History Related ---------------------------------------------------------

Powered by Google App Engine
This is Rietveld 408576698