Issue 2037011: Remove the deprecated static metrics APIs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2037011: Remove the deprecated static metrics APIs. (Closed)

Created:
10 years, 7 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
kmixter1, sosa

CC:
chromium-os-reviews_chromium.org, petkov, Luigi Semenzato, sosa

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

Remove the deprecated static metrics APIs.

Patch Set 1 #

Total comments: 1

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+19 lines, -53 lines)			Patch
M	src/platform/crash/crash_reporter.cc	View	3 chunks	+8 lines, -6 lines	0 comments	Download
M	src/platform/metrics/README	View	1 chunk	+3 lines, -8 lines	0 comments	Download
M	src/platform/metrics/metrics_client.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/platform/metrics/metrics_library.h	View	3 chunks	+0 lines, -14 lines	1 comment	Download
M	src/platform/metrics/metrics_library.cc	View	4 chunks	+4 lines, -23 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

petkov

Trying to push this before possible deprecated API proliferation. I'll rev both metrics and crash-reporter ...

10 years, 7 months ago (2010-05-12 20:38:05 UTC) #1

sosa

10 years, 7 months ago (2010-05-12 22:04:09 UTC) #2

lgtm.

http://codereview.chromium.org/2037011/diff/1/6
File src/platform/metrics/metrics_library.h (left):

http://codereview.chromium.org/2037011/diff/1/6#oldcode11
src/platform/metrics/metrics_library.h:11: 
Sadness

Expand Messages | Collapse Messages