Fix modprobe prob in gmergefs and bring call script into scripts

Fix modprobe prob in gmergefs and bring call script into scripts

TEST=Ran "gmergefs --remote my_device gmerge" resulted in having
gmerge installed into my /usr/local dir on my device

[sosa, 2010-05-11 05:20:55]

Gmergefs hangs if you type the wrong remote ip address or pass a debug flag.  I
noticed this.  Hopefully I can add some todo's to make the error more clear to
developers.  I'm going to go ahead and write some docs on how to use now that it
seems to work.

[Chris Masone, 2010-05-11 17:38:55]

http://codereview.chromium.org/2037006/diff/1/2
File src/platform/dev/gmergefs (right):

http://codereview.chromium.org/2037006/diff/1/2#newcode18
src/platform/dev/gmergefs:18: restart_in_chroot_if_needed $*
I don't understand why we're trying to support people doing things outside the
chroot that make no sense.  Who's running emerge commands outside the chroot and
expecting them to work?

http://codereview.chromium.org/2037006/diff/1/3
File src/scripts/gmergefs (right):

http://codereview.chromium.org/2037006/diff/1/3#newcode13
src/scripts/gmergefs:13: restart_in_chroot_if_needed $*
why don't we just have this assert_inside_chroot?  I mean, who's emerging
packages from outside the chroot?

[sosa, 2010-05-11 22:29:43]

Changed to asserts. I agree it might be a bad idea to do the restarts rather
than asserts, but it is nice to stay outside the chroot in bash if you don't
need to be in the chroot.  I know the testing infrastructure script can all be
run in and outside (but prob should just run inside).  We probably should make a
systematic decision ... and enforce it as a team

http://codereview.chromium.org/2037006/diff/1/2
File src/platform/dev/gmergefs (right):

http://codereview.chromium.org/2037006/diff/1/2#newcode18
src/platform/dev/gmergefs:18: restart_in_chroot_if_needed $*
On 2010/05/11 17:38:55, cmasone wrote:
> I don't understand why we're trying to support people doing things outside the
> chroot that make no sense.  Who's running emerge commands outside the chroot
and
> expecting them to work?

Done.

[Chris Masone, 2010-05-12 15:17:14]

Yeah.  Well, this LGTM at least.

On 2010/05/11 22:29:43, sosa wrote:
> Changed to asserts. I agree it might be a bad idea to do the restarts rather
> than asserts, but it is nice to stay outside the chroot in bash if you don't
> need to be in the chroot.  I know the testing infrastructure script can all be
> run in and outside (but prob should just run inside).  We probably should make
a
> systematic decision ... and enforce it as a team
> 
> http://codereview.chromium.org/2037006/diff/1/2
> File src/platform/dev/gmergefs (right):
> 
> http://codereview.chromium.org/2037006/diff/1/2#newcode18
> src/platform/dev/gmergefs:18: restart_in_chroot_if_needed $*
> On 2010/05/11 17:38:55, cmasone wrote:
> > I don't understand why we're trying to support people doing things outside
the
> > chroot that make no sense.  Who's running emerge commands outside the chroot
> and
> > expecting them to work?
> 
> Done.