Issue 2037005: AU: check after 2 min, also every 30 min.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2037005: AU: check after 2 min, also every 30 min. (Closed)

Created:
10 years, 7 months ago by adlr

Modified:
9 years ago

Reviewers:
davidjames

CC:
chromium-os-reviews_chromium.org, dneiss, adlr

Base URL:
ssh://git@chromiumos-git/chromeos

Visibility:
Public.

Description

AU: check after 2 min, also every 30 min. also, send updaterversion with omaha request. also, log to /var/log/update_engine.log BUG=None TEST=tested on device

Patch Set 2 : fix misspelling #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -2 lines)			Patch
	M	src/platform/update_engine/main.cc	View	1	4 chunks	+30 lines, -1 line	0 comments	Download
	M	src/platform/update_engine/update_check_action.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

adlr

David, if you don't mind doing this review on the earlier side, it'd be much ...

10 years, 7 months ago (2010-05-10 20:26:09 UTC) #1

davidjames

LGTM w/nits. http://codereview.chromium.org/2037005/diff/1/2 File src/platform/update_engine/main.cc (right): http://codereview.chromium.org/2037005/diff/1/2#newcode89 src/platform/update_engine/main.cc:89: logging::InitLogging("/var/log/update_engine.log", Could you update your commit message ...

10 years, 7 months ago (2010-05-10 20:41:02 UTC) #2

Thanks for the quick review! Fixed and submitted

Expand Messages | Collapse Messages

Issue 2037005: AU: check after 2 min, also every 30 min. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix misspelling #

Messages