Issue 2037004: more clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2037004: more clang (Closed)

Created:
10 years, 7 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
Nico, Rico, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Use this->Foo() in some places due to two-phase lookup. This is required by more strict compilers (Clang). Committed: http://code.google.com/p/v8/source/detail?r=4908

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	src/objects.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Rico

Drive by comment: This cl is against trunk and should be against bleeding_edge (see http://code.google.com/p/v8/wiki/Source?tm=4 ...

10 years, 6 months ago (2010-06-13 13:54:44 UTC) #2

Mads Ager (chromium)

10 years, 6 months ago (2010-06-14 06:47:49 UTC) #3

LGTM

Please make sure to land this in the bleeding_edge branch as pointed out by
Rico.