Issue 2035007: Use a reasonable default pthread stack size on Mac OS X

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2035007: Use a reasonable default pthread stack size on Mac OS X (Closed)

Created:
10 years, 7 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Use a reasonable default pthread stack size on Mac OS X. Mac OS X uses a fixed default stack size of 512kB, which is too small for some purposes. glibc on Linux uses ulimit -s, which is both a more reasonable thing to do, and is generally set to a rational limit, such as 8MB. BUG=43422 TEST=None really on the trunk. On the Mac 375 branch, using the .pac file on the bug, Chrome should not crash on startup. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46717

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+33 lines, -0 lines)			Patch
	M	base/platform_thread_posix.cc	View		2 chunks	+33 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages