Fix a possible crash introduced by r46412 by not accessing the result variabl...

Fix a possible crash introduced by r46412 by not accessing the result variable before the NULL check

BUG=43408
TEST=none

Patch by Benjamin Jemlich <pcgod99@gmail.com>;.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46614

[stuartmorgan, 2010-05-06 15:35:07]

http://codereview.chromium.org/2035003/diff/1/2
File chrome/browser/password_manager/password_store_default.cc (right):

http://codereview.chromium.org/2035003/diff/1/2#newcode119
chrome/browser/password_manager/password_store_default.cc:119: DCHECK(result);
If this is actually happening, then either the DCHECK shouldn't be here, or
there is an underlying bug that should also be addressed.

[pcgod99, 2010-05-06 16:13:05]

On 2010/05/06 15:35:07, stuartmorgan wrote:
> http://codereview.chromium.org/2035003/diff/1/2
> File chrome/browser/password_manager/password_store_default.cc (right):
> 
> http://codereview.chromium.org/2035003/diff/1/2#newcode119
> chrome/browser/password_manager/password_store_default.cc:119: DCHECK(result);
> If this is actually happening, then either the DCHECK shouldn't be here, or
> there is an underlying bug that should also be addressed.

result is NULL if the web database initialization failed (I could force the
crash by removing all permissions on "Web Data") so I think it's safe to remove
the DCHECK

[albertb, 2010-05-06 16:39:44]

LGTM

In theory, result could also be NULL if the WDS is shutdown while the migration
GetLogins calls are in flight.

[stuartmorgan, 2010-05-06 16:54:55]

LGTM

[Evan Martin, 2010-05-06 20:43:46]

committed, thanks