Fix some focus traversal issues:...

chrome/views/focus_manager.cc

 // Copyright (c) 2006-2008 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <algorithm>
 
 #include "base/histogram.h"
 #include "base/logging.h"
 #include "base/win_util.h"
 #include "chrome/browser/renderer_host/render_widget_host_view_win.h"
@@ skipping 451 matching lines @@
   while (window) {
     if (window == root_)
       return true;
     window = ::GetParent(window);
   }
   return false;
 }
 
 void FocusManager::AdvanceFocus(bool reverse) {
   View* v = GetNextFocusableView(focused_view_, reverse, false);
-  if (v && (v != focused_view_)) {
+  // Note: Do not skip this next block when v == focused_view_.  If the user
+  // tabs past the last focusable element in a webpage, we'll get here, and if
+  // the TabContentsContainerView is the only focusable view (possible in
+  // fullscreen mode), we need to run this block in order to cycle around to the
+  // first element on the page.
+  if (v) {
     v->AboutToRequestFocusFromTabTraversal(reverse);
     v->RequestFocus();
   }
 }
 
 View* FocusManager::GetNextFocusableView(View* original_starting_view,
                                          bool reverse,
                                          bool dont_loop) {
   FocusTraversable* focus_traversable = NULL;
 
@@ skipping 63 matching lines @@
           // top_root_view.
           return GetNextFocusableView(NULL, false, true);
         }
       }
     }
   }
   return NULL;
 }
 
 View* FocusManager::FindLastFocusableView() {
-  // For now we'll just walk the entire focus loop until we reach the end.
-
-  // Let's start at whatever focused view we are at.
-  View* starting_view = focused_view_;
-
-  // Now advance until you reach the end.
+  // Just walk the entire focus loop from where we're at until we reach the end.
   View* new_focused = NULL;
-  View* last_focused = NULL;
-  while (new_focused = GetNextFocusableView(starting_view, false, true)) {
+  View* last_focused = focused_view_;
+  while (new_focused = GetNextFocusableView(last_focused, false, true))
     last_focused = new_focused;
-    starting_view = new_focused;
-  }
   return last_focused;
 }
 
 void FocusManager::SetFocusedView(View* view) {
   if (focused_view_ != view) {
     View* prev_focused_view = focused_view_;
     if (focused_view_)
       focused_view_->WillLoseFocus();
 
     if (view)
@@ skipping 254 matching lines @@
                 listener);
   if (place == focus_change_listeners_.end()) {
     NOTREACHED() << "Removing a listener that isn't registered.";
     return;
   }
   focus_change_listeners_.erase(place);
 }
 
 }  // namespace views