Remove refcounting from SavePackage.

content/browser/download/save_package.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/download/save_package.h"
 
 #include <algorithm>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 324 matching lines @@
 
   // Check save type and process the save page job.
   if (save_type_ == SAVE_PAGE_TYPE_AS_COMPLETE_HTML) {
     // Get directory
     DCHECK(!saved_main_directory_path_.empty());
     GetSavableResourceLinks();
   } else if (save_type_ == SAVE_PAGE_TYPE_AS_MHTML) {
     MHTMLGenerationParams mhtml_generation_params(saved_main_file_path_);
     web_contents()->GenerateMHTML(
         mhtml_generation_params,
-        base::Bind(&SavePackage::OnMHTMLGenerated, this));
+        base::Bind(&SavePackage::OnMHTMLGenerated, Unretained(this)));
   } else {
     DCHECK_EQ(SAVE_PAGE_TYPE_AS_ONLY_HTML, save_type_);
     wait_state_ = NET_FILES;
     SaveFileCreateInfo::SaveFileSource save_source = page_url_.SchemeIsFile() ?
         SaveFileCreateInfo::SAVE_FILE_FROM_FILE :
         SaveFileCreateInfo::SAVE_FILE_FROM_NET;
     // Add this item to waiting list.
     waiting_item_queue_.push_back(
         new SaveItem(page_url_, Referrer(), this, save_source,
                      FrameTreeNode::kFrameTreeNodeInvalidId));
@@ skipping 20 matching lines @@
     // ShouldCompleteDownload() may depend on the gdata uploader to finish.
     download_->OnAllDataSaved(size, std::unique_ptr<crypto::SecureHash>());
   }
 
   if (!download_manager_->GetDelegate()) {
     Finish();
     return;
   }
 
   if (download_manager_->GetDelegate()->ShouldCompleteDownload(
-          download_, base::Bind(&SavePackage::Finish, this))) {
+          download_,
+          base::Bind(&SavePackage::Finish, base::Unretained(this)))) {
     Finish();
   }
 }
 
 // On POSIX, the length of |pure_file_name| + |file_name_ext| is further
 // restricted by NAME_MAX. The maximum allowed path looks like:
 // '/path/to/save_dir' + '/' + NAME_MAX.
 uint32_t SavePackage::GetMaxPathLengthForDirectory(
     const base::FilePath& base_dir) {
 #if defined(OS_POSIX)
@@ skipping 978 matching lines @@
   bool skip_dir_check = false;
   auto* delegate = download_manager_->GetDelegate();
   if (delegate) {
     delegate->GetSaveDir(
         web_contents()->GetBrowserContext(), &website_save_dir,
         &download_save_dir, &skip_dir_check);
   }
   std::string mime_type = web_contents()->GetContentsMimeType();
   BrowserThread::PostTask(
       BrowserThread::FILE, FROM_HERE,
-      base::Bind(&SavePackage::CreateDirectoryOnFileThread, this,
-          website_save_dir, download_save_dir, skip_dir_check, mime_type));
+      base::Bind(&SavePackage::CreateDirectoryOnFileThread,
+                 base::Unretained(this), website_save_dir, download_save_dir,
+                 skip_dir_check, mime_type));
 }
 
 void SavePackage::CreateDirectoryOnFileThread(
     const base::FilePath& website_save_dir,
     const base::FilePath& download_save_dir,
     bool skip_dir_check,
     const std::string& mime_type) {
   DCHECK_CURRENTLY_ON(BrowserThread::FILE);
 
   base::FilePath save_dir;
@@ skipping 26 matching lines @@
   } else {
     // Cannot create a shorter filename. This will cause the save as operation
     // to fail unless the user pick a shorter name. Continuing even though it
     // will fail because returning means no save as popup for the user, which
     // is even more confusing. This case should be rare though.
     save_dir = save_dir.Append(suggested_filename);
   }
 
   BrowserThread::PostTask(
       BrowserThread::UI, FROM_HERE,
-      base::Bind(&SavePackage::ContinueGetSaveInfo, this, save_dir,
-                 can_save_as_complete));
+      base::Bind(&SavePackage::ContinueGetSaveInfo, base::Unretained(this),
+                 save_dir, can_save_as_complete));
 }
 
 void SavePackage::ContinueGetSaveInfo(const base::FilePath& suggested_path,
                                       bool can_save_as_complete) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
   // The WebContents which owns this SavePackage may have disappeared during
   // the UI->FILE->UI thread hop of
   // GetSaveInfo->CreateDirectoryOnFileThread->ContinueGetSaveInfo.
   if (!web_contents() || !download_manager_->GetDelegate())
@@ skipping 51 matching lines @@
 }
 
 void SavePackage::FinalizeDownloadEntry() {
   DCHECK(download_);
 
   download_manager_->OnSavePackageSuccessfullyFinished(download_);
   StopObservation();
 }
 
 }  // namespace content