Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 20319: Update d8 preemption mode to support multiple files per line. Each line is r... (Closed)

Created:
11 years, 10 months ago by Patrick Johnson
Modified:
9 years, 7 months ago
Reviewers:
iposva
CC:
v8-dev
Visibility:
Public.

Description

Update d8 preemption mode to support multiple files per line. Each line is run in its own context. Files are separated by spaces, and will be run in order, left to right. Also add support for comment lines, which start with '#'. Committed: http://code.google.com/p/v8/source/detail?r=1306

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -16 lines) Patch
M src/d8.cc View 1 2 chunks +52 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Patrick Johnson
11 years, 10 months ago (2009-02-12 19:41:38 UTC) #1
iposva
Please make sure you work with Christian to adapt the "Debug Preempt" testing step. Otherwise ...
11 years, 10 months ago (2009-02-13 00:13:58 UTC) #2
Patrick Johnson
11 years, 10 months ago (2009-02-13 18:25:33 UTC) #3
Thanks for the review.  I'll make sure the step is ready to go before committing
this code.

http://codereview.chromium.org/20319/diff/1/2
File src/d8.cc (right):

http://codereview.chromium.org/20319/diff/1/2#newcode505
Line 505: if (next_word != NULL) {
On 2009/02/13 00:13:58, iposva wrote:
> Since you already abstracted ReadLine() you might want to pull this out into a
> ReadWord() function. That way the name of the function documents what you are
> after.

Good point, done.

Powered by Google App Engine
This is Rietveld 408576698