Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 2031004: Revert 46567 - Reimplement accessibility of web content by caching the entire... (Closed)

Created:
10 years, 7 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, jam+cc_chromium.org, Paweł Hajdan Jr., brettw-cc_chromium.org, darin-cc_chromium.org, ben+cc_chromium.org
Visibility:
Public.

Description

Revert 46567 - Reimplement accessibility of web content by caching the entire accessibility tree in the browser process. Adds new RPCs for a browser tab to request accessibility info from a renderer; the renderer responds with a complete tree of accessibility metadata for the entire DOM, which is then cached in the RenderWidgetHostView. This part is crossplatform and will help with accessibility on both Windows and Mac OS X. For Windows, MSAA support for web content has been rewritten to use this new cache. Tested in JAWS and NVDA screen readers. Using Chrome with a screen reader is now fast and stable, unlike the previous implementation. However, note that most advanced functionality is still not supported, and much work remains to make Chrome work well with a screen reader. This is a necessary step to improve stability first. BUG=25564 BUG=13291 TEST=See http://codereview.chromium.org/1806001 Review URL: http://codereview.chromium.org/1637018 TBR=dmazzoni@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1087 lines, -5483 lines) Patch
M chrome/browser/browser_accessibility.h View 5 chunks +71 lines, -170 lines 0 comments Download
M chrome/browser/browser_accessibility.cc View 9 chunks +314 lines, -341 lines 0 comments Download
M chrome/browser/browser_accessibility_manager.h View 1 chunk +71 lines, -69 lines 0 comments Download
M chrome/browser/browser_accessibility_manager.cc View 2 chunks +128 lines, -97 lines 0 comments Download
D chrome/browser/browser_accessibility_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.h View 3 chunks +0 lines, -5 lines 0 comments Download
M chrome/browser/renderer_host/render_view_host.cc View 3 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.h View 5 chunks +2 lines, -17 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_win.cc View 4 chunks +28 lines, -58 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.h View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/tab_contents/tab_contents.cc View 4 chunks +1 line, -12 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +0 lines, -4 lines 0 comments Download
M chrome/common/render_messages.h View 2 chunks +75 lines, -66 lines 0 comments Download
M chrome/common/render_messages_internal.h View 3 chunks +14 lines, -8 lines 0 comments Download
D chrome/common/render_messages_unittest.cc View 1 chunk +0 lines, -96 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/render_view.h View 4 chunks +6 lines, -4 lines 0 comments Download
M chrome/renderer/render_view.cc View 5 chunks +46 lines, -9 lines 0 comments Download
D third_party/iaccessible2/ia2_api_all.idl View 1 chunk +0 lines, -4263 lines 0 comments Download
D third_party/iaccessible2/iaccessible2.gyp View 1 chunk +0 lines, -41 lines 0 comments Download
M webkit/glue/webaccessibility.h View 4 chunks +110 lines, -42 lines 0 comments Download
M webkit/glue/webaccessibility.cc View 3 chunks +206 lines, -43 lines 0 comments Download
A + webkit/glue/webaccessibilitymanager.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Zachary Kuznia
10 years, 7 months ago (2010-05-07 00:39:30 UTC) #1
dmazzoni
10 years, 7 months ago (2010-05-07 01:25:33 UTC) #2
LGTM

Sorry this CL caused problems! What test was failing?

Powered by Google App Engine
This is Rietveld 408576698