Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2031002: Enforce image update from image_to_live. (Closed)

Created:
10 years, 7 months ago by ericli
Modified:
9 years, 7 months ago
Reviewers:
kmixter1
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Enforce image update from image_to_live. The issue here is if an previous update succeeded but reboot not happen, for what ever unknown reason, this host lost the ability to update again. I think some of the current update failure in the lab should be caused by this.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/scripts/image_to_live.sh View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ericli
10 years, 7 months ago (2010-05-06 21:35:01 UTC) #1
kmixter1
10 years, 7 months ago (2010-05-06 22:13:54 UTC) #2
LGTM

On Thu, May 6, 2010 at 2:35 PM,  <ericli@chromium.org> wrote:
> Reviewers: kmixter1,
>
> Description:
> Enforce image update from image_to_live.
>
> The issue here is if an previous update succeeded but reboot not happen, for
> what ever unknown reason, this host lost the ability to update again.
>
> I think some of the current update failure in the lab should be caused by
> this.
>
> Please review this at http://codereview.chromium.org/2031002/show
>
> SVN Base: ssh://git@chromiumos-git/chromeos
>
> Affected files:
>  M src/scripts/image_to_live.sh
>
>
> Index: src/scripts/image_to_live.sh
> diff --git a/src/scripts/image_to_live.sh b/src/scripts/image_to_live.sh
> index
>
64e020f3ca895b4340f26c7d51927252e88db78a..3eaa8fdeacca1ad877bb68cb0c0d653a17c75db3
> 100755
> --- a/src/scripts/image_to_live.sh
> +++ b/src/scripts/image_to_live.sh
> @@ -99,8 +99,10 @@ function run_auto_update {
>   # Clear it out so we don't see a prior run and make sure it
>   # exists so the first tail below can't fail if it races the
>   # memento updater first write and wins.
> -  remote_sh "rm -f ${update_file}; touch ${update_file}; \
> -      /opt/google/memento_updater/memento_updater.sh</dev/null>&/dev/null&"
> +  remote_sh "rm -f /tmp/memento_autoupdate_completed; rm -f ${update_file};
> \
> +      touch ${update_file}; \
> +      /opt/google/memento_updater/memento_updater.sh --force_update <
> /dev/null\
> +      >&/dev/null&"
>
>   local update_error
>   local output_file
>
>
>

Powered by Google App Engine
This is Rietveld 408576698