Implement GetCurrentCountryID() for Linux....

Implement GetCurrentCountryID() for Linux.

This CL implements GetCurrentCountryID() function for Linux.

BUG=none
TEST=none

[James Su, 2009-09-16 11:23:54]

Please help review this CL.

Thanks
James Su

[Peter Kasting, 2009-09-16 18:32:12]

LGTM, but you might want to rewrite slightly.

http://codereview.chromium.org/203079/diff/1/2
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

http://codereview.chromium.org/203079/diff/1/2#newcode2792
Line 2792: const char* locale = setlocale(LC_MESSAGES, NULL);
Nit: I suggest using a std::string() instead of a char*, which will let you make
calls like Find(), eliminating the loop below and producing slightly more
readable/safer code.

[James Su, 2009-09-16 23:30:38]

Thanks for your suggestion. CL has been updated to use std::string().

Regards
James Su

On 2009/09/16 18:32:12, Peter Kasting wrote:
> LGTM, but you might want to rewrite slightly.
> 
> http://codereview.chromium.org/203079/diff/1/2
> File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):
> 
> http://codereview.chromium.org/203079/diff/1/2#newcode2792
> Line 2792: const char* locale = setlocale(LC_MESSAGES, NULL);
> Nit: I suggest using a std::string() instead of a char*, which will let you
make
> calls like Find(), eliminating the loop below and producing slightly more
> readable/safer code.

[Peter Kasting, 2009-09-16 23:35:10]

LGTM

http://codereview.chromium.org/203079/diff/5001/6001
File chrome/browser/search_engines/template_url_prepopulate_data.cc (right):

http://codereview.chromium.org/203079/diff/5001/6001#newcode2801
Line 2801: std::string::size_type begin = locale_str.find('_');
Nit: After some discussion a while back, we agreed to use "size_t" across the
codebase instead of "std::string::size_type".

http://codereview.chromium.org/203079/diff/5001/6001#newcode2805
Line 2805: begin++;
Nit: I'd prefer preincrement to post except where necessary