Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1014)

Unified Diff: views/focus/focus_manager_gtk.cc

Issue 203073: Lands http://codereview.chromium.org/193032 for Charlie:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « views/controls/native_control_gtk.cc ('k') | views/window/dialog_client_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: views/focus/focus_manager_gtk.cc
===================================================================
--- views/focus/focus_manager_gtk.cc (revision 26217)
+++ views/focus/focus_manager_gtk.cc (working copy)
@@ -20,7 +20,7 @@
gtk_widget_grab_focus(native_view);
}
- // static
+// static
FocusManager* FocusManager::GetFocusManagerForNativeView(
gfx::NativeView native_view) {
GtkWidget* root = gtk_widget_get_toplevel(native_view);
@@ -29,7 +29,9 @@
WidgetGtk* widget = WidgetGtk::GetViewForNative(root);
if (!widget) {
- NOTREACHED();
+ // TODO(jcampan): http://crbug.com/21378 Reenable this NOTREACHED() when the
+ // options page is only based on views.
+ // NOTREACHED();
return NULL;
}
FocusManager* focus_manager = widget->GetFocusManager();
« no previous file with comments | « views/controls/native_control_gtk.cc ('k') | views/window/dialog_client_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698