Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 203071: Linux: add support for SELinux. (Closed)

Created:
11 years, 3 months ago by agl
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Linux: add support for SELinux. This patch adds support for a selinux GYP variable which, when set to one, does the following: * Removes the seccomp sandbox from the compile * Removes support for SUID sandboxing from the zygote * Performs a dynamic transition, in the zygote, to chromium_renderer_t. This code requires that the system policy have a sensible set of access vectors for the chromium_renderer_t type. Such a policy will be found in sandbox/selinux in the future.

Patch Set 1 #

Total comments: 5
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -22 lines) Patch
M build/common.gypi View 2 chunks +6 lines, -0 lines 0 comments Download
M build/linux/system.gyp View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/zygote_main_linux.cc View 5 chunks +60 lines, -16 lines 5 comments Download
M chrome/chrome.gyp View 3 chunks +15 lines, -4 lines 0 comments Download
M chrome/renderer/renderer_main_platform_delegate_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/sandbox.gyp View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
agl
11 years, 3 months ago (2009-09-15 17:44:49 UTC) #1
Evan Martin
I'm not sure I'm a good person for reviewing security-sensitive code. Do you know anyone ...
11 years, 3 months ago (2009-09-15 18:42:11 UTC) #2
Evan Martin
looks good, one point of confusion about changing that global flag http://codereview.chromium.org/203071/diff/1/4 File chrome/browser/zygote_main_linux.cc (right): ...
11 years, 3 months ago (2009-09-15 18:45:51 UTC) #3
Amanda Walker
11 years, 3 months ago (2009-09-15 19:06:07 UTC) #4
On 2009/09/15 18:42:11, Evan Martin wrote:
> I'm not sure I'm a good person for reviewing security-sensitive code.  Do you
> know anyone else who could help with selinux-related stuff?

LGTM for the SELinux stuff.

Powered by Google App Engine
This is Rietveld 408576698