Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: chrome/browser/views/toolbar_view.cc

Issue 203029: [Windows] Bookmark-menu button should be themed like any other menu button.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/views/bookmark_menu_button.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/toolbar_view.h" 5 #include "chrome/browser/views/toolbar_view.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "app/drag_drop_types.h" 9 #include "app/drag_drop_types.h"
10 #include "app/gfx/canvas.h" 10 #include "app/gfx/canvas.h"
(...skipping 864 matching lines...) Expand 10 before | Expand all | Expand 10 after
875 page_menu_->SetTooltipText(l10n_util::GetString(IDS_PAGEMENU_TOOLTIP)); 875 page_menu_->SetTooltipText(l10n_util::GetString(IDS_PAGEMENU_TOOLTIP));
876 page_menu_->SetID(VIEW_ID_PAGE_MENU); 876 page_menu_->SetID(VIEW_ID_PAGE_MENU);
877 877
878 878
879 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false); 879 app_menu_ = new views::MenuButton(NULL, std::wstring(), this, false);
880 app_menu_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_APP)); 880 app_menu_->SetAccessibleName(l10n_util::GetString(IDS_ACCNAME_APP));
881 app_menu_->SetTooltipText(l10n_util::GetStringF(IDS_APPMENU_TOOLTIP, 881 app_menu_->SetTooltipText(l10n_util::GetStringF(IDS_APPMENU_TOOLTIP,
882 l10n_util::GetString(IDS_PRODUCT_NAME))); 882 l10n_util::GetString(IDS_PRODUCT_NAME)));
883 app_menu_->SetID(VIEW_ID_APP_MENU); 883 app_menu_->SetID(VIEW_ID_APP_MENU);
884 884
885 LoadRightSideControlsImages();
886
887 AddChildView(page_menu_);
888 AddChildView(app_menu_);
889
890 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kBookmarkMenu)) { 885 if (CommandLine::ForCurrentProcess()->HasSwitch(switches::kBookmarkMenu)) {
891 bookmark_menu_ = new BookmarkMenuButton(browser_); 886 bookmark_menu_ = new BookmarkMenuButton(browser_);
892 AddChildView(bookmark_menu_); 887 AddChildView(bookmark_menu_);
893 } else { 888 } else {
894 bookmark_menu_ = NULL; 889 bookmark_menu_ = NULL;
895 } 890 }
891
892 LoadRightSideControlsImages();
893
894 AddChildView(page_menu_);
895 AddChildView(app_menu_);
896 } 896 }
897 897
898 void ToolbarView::LoadLeftSideControlsImages() { 898 void ToolbarView::LoadLeftSideControlsImages() {
899 ThemeProvider* tp = GetThemeProvider(); 899 ThemeProvider* tp = GetThemeProvider();
900 900
901 SkColor color = tp->GetColor(BrowserThemeProvider::COLOR_BUTTON_BACKGROUND); 901 SkColor color = tp->GetColor(BrowserThemeProvider::COLOR_BUTTON_BACKGROUND);
902 SkBitmap* background = tp->GetBitmapNamed(IDR_THEME_BUTTON_BACKGROUND); 902 SkBitmap* background = tp->GetBitmapNamed(IDR_THEME_BUTTON_BACKGROUND);
903 903
904 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK)); 904 back_->SetImage(views::CustomButton::BS_NORMAL, tp->GetBitmapNamed(IDR_BACK));
905 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H)); 905 back_->SetImage(views::CustomButton::BS_HOT, tp->GetBitmapNamed(IDR_BACK_H));
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
977 977
978 // We use different menu button images if the locale is right-to-left. 978 // We use different menu button images if the locale is right-to-left.
979 if (UILayoutIsRightToLeft()) 979 if (UILayoutIsRightToLeft())
980 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE_RTL)); 980 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE_RTL));
981 else 981 else
982 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE)); 982 page_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_PAGE));
983 if (UILayoutIsRightToLeft()) 983 if (UILayoutIsRightToLeft())
984 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME_RTL)); 984 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME_RTL));
985 else 985 else
986 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME)); 986 app_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_CHROME));
987
988 if (bookmark_menu_ != NULL)
989 bookmark_menu_->SetIcon(*tp->GetBitmapNamed(IDR_MENU_BOOKMARK));
987 } 990 }
988 991
989 void ToolbarView::RunPageMenu(const gfx::Point& pt, gfx::NativeView parent) { 992 void ToolbarView::RunPageMenu(const gfx::Point& pt, gfx::NativeView parent) {
990 CreatePageMenu(); 993 CreatePageMenu();
991 page_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT); 994 page_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
992 } 995 }
993 996
994 void ToolbarView::RunAppMenu(const gfx::Point& pt, gfx::NativeView parent) { 997 void ToolbarView::RunAppMenu(const gfx::Point& pt, gfx::NativeView parent) {
995 CreateAppMenu(); 998 CreateAppMenu();
996 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT); 999 app_menu_menu_->RunMenuAt(pt, views::Menu2::ALIGN_TOPRIGHT);
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
1093 app_menu_contents_->AddItem(IDC_ABOUT, 1096 app_menu_contents_->AddItem(IDC_ABOUT,
1094 l10n_util::GetStringFUTF16( 1097 l10n_util::GetStringFUTF16(
1095 IDS_ABOUT, 1098 IDS_ABOUT,
1096 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME))); 1099 l10n_util::GetStringUTF16(IDS_PRODUCT_NAME)));
1097 app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE); 1100 app_menu_contents_->AddItemWithStringId(IDC_HELP_PAGE, IDS_HELP_PAGE);
1098 app_menu_contents_->AddSeparator(); 1101 app_menu_contents_->AddSeparator();
1099 app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT); 1102 app_menu_contents_->AddItemWithStringId(IDC_EXIT, IDS_EXIT);
1100 1103
1101 app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get())); 1104 app_menu_menu_.reset(new views::Menu2(app_menu_contents_.get()));
1102 } 1105 }
OLDNEW
« no previous file with comments | « chrome/browser/views/bookmark_menu_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698