Issue 203018: Resubmit suppression count report patch, but this time don't crash if that se...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 203018: Resubmit suppression count report patch, but this time don't crash if that se... (Closed)

Created:
11 years, 3 months ago by dank

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, not_the_right_glider, Nirnimesh, dank, the_wrong_timurrrr, stuartmorgan, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Resubmit suppression count report patch, but this time don't crash if that section of the xml file is missing/empty Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25876

Patch Set 1 #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -6 lines)			Patch
	M	tools/valgrind/memcheck_analyze.py	View		4 chunks	+39 lines, -6 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

dank

http://codereview.chromium.org/203009, take two Should fix crash seen in http://build.chromium.org/buildbot/waterfall/builders/Chromium%20Mac%20(valgrind)/builds/1681/steps/valgrind%20test:%20base/logs/stdio

11 years, 3 months ago (2009-09-10 17:44:37 UTC) #1

LGTM

Expand Messages | Collapse Messages