Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 203016: Implement code patcher for x64 (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Implement code patcher for x64. Use the code patcher for the patching of the JS return sequence used by the debugger. Added explicit instruction cache flushing in a code patching section which did not have it for completeness, even though it is not required on Intel processors. Committed: http://code.google.com/p/v8/source/detail?r=2870

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -14 lines) Patch
M src/ia32/assembler-ia32.cc View 1 2 chunks +17 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.cc View 1 2 chunks +25 lines, -12 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 chunk +22 lines, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-10 12:01:02 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/203016/diff/1/3 File src/x64/assembler-x64.cc (right): http://codereview.chromium.org/203016/diff/1/3#newcode184 Line 184: patcher.masm()->call(r10); Could you add a (debug only) ...
11 years, 3 months ago (2009-09-10 12:33:12 UTC) #2
Søren Thygesen Gjesse
11 years, 3 months ago (2009-09-10 12:57:54 UTC) #3
http://codereview.chromium.org/203016/diff/1/3
File src/x64/assembler-x64.cc (right):

http://codereview.chromium.org/203016/diff/1/3#newcode184
Line 184: patcher.masm()->call(r10);
On 2009/09/10 12:33:12, Lasse Reichstein wrote:
> Could you add a (debug only) assertion that the patcher's
> masm's pc_offset is pc_+13 at this point?

Done. Added that to the IA32 version as well.

Powered by Google App Engine
This is Rietveld 408576698