Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6802)

Unified Diff: chrome/browser/gtk/bookmark_bar_gtk.cc

Issue 203010: GTK: fix bookmark bar regression:... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: plusplus readability Created 11 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/gtk/bookmark_bar_gtk.cc
===================================================================
--- chrome/browser/gtk/bookmark_bar_gtk.cc (revision 25765)
+++ chrome/browser/gtk/bookmark_bar_gtk.cc (working copy)
@@ -977,9 +977,16 @@
DCHECK(page_navigator_);
int first_hidden = GetFirstHiddenBookmark(0, NULL);
- if (button != overflow_button_ && button != other_bookmarks_button_ &&
- node->GetParent()->IndexOfChild(node) >= first_hidden) {
- return;
+ if (first_hidden == -1) {
+ // No overflow exists: don't show anything for the overflow button.
+ if (button == overflow_button_)
+ return;
+ } else {
+ // Overflow exists: don't show anything for an overflowed folder button.
+ if (button != overflow_button_ && button != other_bookmarks_button_ &&
+ node->GetParent()->IndexOfChild(node) >= first_hidden) {
+ return;
+ }
}
current_menu_.reset(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698