sliding animation for moles

sliding animation for moles

BUG=15494
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=25859

[Finnur, 2009-09-09 23:39:00]

LG only a nit and a question...

http://codereview.chromium.org/203004/diff/2001/3001
File chrome/browser/views/extensions/extension_shelf.cc (right):

http://codereview.chromium.org/203004/diff/2001/3001#newcode123
Line 123: virtual gfx::Size GetHandlePreferredSize();
Does this need to be virtual?

http://codereview.chromium.org/203004/diff/2001/3001#newcode420
Line 420: }
A little bit of explanation here would probably go a long way for someone new to
this code. :)

[Erik does not do reviews, 2009-09-09 23:47:10]

http://codereview.chromium.org/203004/diff/2001/3001
File chrome/browser/views/extensions/extension_shelf.cc (right):

http://codereview.chromium.org/203004/diff/2001/3001#newcode123
Line 123: virtual gfx::Size GetHandlePreferredSize();
On 2009/09/09 23:39:00, Finnur wrote:
> Does this need to be virtual?

nope.  good catch.

http://codereview.chromium.org/203004/diff/2001/3001#newcode420
Line 420: }
On 2009/09/09 23:39:00, Finnur wrote:
> A little bit of explanation here would probably go a long way for someone new
to
> this code. :)

good point.  comments added.

[Finnur, 2009-09-10 03:26:54]

LG

On 2009/09/09 23:47:10, Erik Kay wrote:
> http://codereview.chromium.org/203004/diff/2001/3001
> File chrome/browser/views/extensions/extension_shelf.cc (right):
> 
> http://codereview.chromium.org/203004/diff/2001/3001#newcode123
> Line 123: virtual gfx::Size GetHandlePreferredSize();
> On 2009/09/09 23:39:00, Finnur wrote:
> > Does this need to be virtual?
> 
> nope.  good catch.
> 
> http://codereview.chromium.org/203004/diff/2001/3001#newcode420
> Line 420: }
> On 2009/09/09 23:39:00, Finnur wrote:
> > A little bit of explanation here would probably go a long way for someone
new
> to
> > this code. :)
> 
> good point.  comments added.