Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: src/disasm-ia32.cc

Issue 20298: Fix a couple of typos reported as V8 issue 226. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/assembler.h ('k') | src/objects.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2007-2008 the V8 project authors. All rights reserved. 1 // Copyright 2007-2008 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 682 matching lines...) Expand 10 before | Expand all | Expand 10 after
693 case 0xB7: return "movzx_w"; 693 case 0xB7: return "movzx_w";
694 case 0xAF: return "imul"; 694 case 0xAF: return "imul";
695 case 0xA5: return "shld"; 695 case 0xA5: return "shld";
696 case 0xAD: return "shrd"; 696 case 0xAD: return "shrd";
697 case 0xAB: return "bts"; 697 case 0xAB: return "bts";
698 default: return NULL; 698 default: return NULL;
699 } 699 }
700 } 700 }
701 701
702 702
703 // Disassembled instruction '*instr' and writes it intro 'out_buffer'. 703 // Disassembled instruction '*instr' and writes it into 'out_buffer'.
704 int DisassemblerIA32::InstructionDecode(v8::internal::Vector<char> out_buffer, 704 int DisassemblerIA32::InstructionDecode(v8::internal::Vector<char> out_buffer,
705 byte* instr) { 705 byte* instr) {
706 tmp_buffer_pos_ = 0; // starting to write as position 0 706 tmp_buffer_pos_ = 0; // starting to write as position 0
707 byte* data = instr; 707 byte* data = instr;
708 // Check for hints. 708 // Check for hints.
709 const char* branch_hint = NULL; 709 const char* branch_hint = NULL;
710 // We use this two prefixes only with branch prediction 710 // We use these two prefixes only with branch prediction
711 if (*data == 0x3E /*ds*/) { 711 if (*data == 0x3E /*ds*/) {
712 branch_hint = "predicted taken"; 712 branch_hint = "predicted taken";
713 data++; 713 data++;
714 } else if (*data == 0x2E /*cs*/) { 714 } else if (*data == 0x2E /*cs*/) {
715 branch_hint = "predicted not taken"; 715 branch_hint = "predicted not taken";
716 data++; 716 data++;
717 } 717 }
718 bool processed = true; // Will be set to false if the current instruction 718 bool processed = true; // Will be set to false if the current instruction
719 // is not in 'instructions' table. 719 // is not in 'instructions' table.
720 const InstructionDesc& idesc = instruction_table.Get(*data); 720 const InstructionDesc& idesc = instruction_table.Get(*data);
(...skipping 409 matching lines...) Expand 10 before | Expand all | Expand 10 after
1130 } 1130 }
1131 for (int i = 6 - (pc - prev_pc); i >= 0; i--) { 1131 for (int i = 6 - (pc - prev_pc); i >= 0; i--) {
1132 fprintf(f, " "); 1132 fprintf(f, " ");
1133 } 1133 }
1134 fprintf(f, " %s\n", buffer.start()); 1134 fprintf(f, " %s\n", buffer.start());
1135 } 1135 }
1136 } 1136 }
1137 1137
1138 1138
1139 } // namespace disasm 1139 } // namespace disasm
OLDNEW
« no previous file with comments | « src/assembler.h ('k') | src/objects.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698