Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2029009: disable automounting when inside the chroot (Closed)

Created:
10 years, 7 months ago by Chris Masone
Modified:
9 years, 7 months ago
Reviewers:
sosa
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git//chromeos
Visibility:
Public.

Description

disable automounting when inside the chroot Unfortunately, bind mounting /media inside the chroot did not allow us to programmatically unmount automounted USB sticks from within the chroot. Instead, I disable automounting on our corporate desktops when you enter the chroot. Your normal setting is restored when you exit the chroot again. TEST=run gconftool-2 -g /apps/nautilus/preferences/media_automount to print the current value of your automount pref; run this before entering the chroot, outside the chroot while you've got some other terminal that's inside the chroot, and then after exiting the chroot.

Patch Set 1 #

Total comments: 1

Patch Set 2 : add check for existence of gconftool-2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -9 lines) Patch
M src/scripts/enter_chroot.sh View 1 5 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Chris Masone
10 years, 7 months ago (2010-05-12 18:57:38 UTC) #1
sosa
http://codereview.chromium.org/2029009/diff/1/2 File src/scripts/enter_chroot.sh (right): http://codereview.chromium.org/2029009/diff/1/2#newcode155 src/scripts/enter_chroot.sh:155: # from inside. Add a check for gconftool exisiting ...
10 years, 7 months ago (2010-05-12 19:21:12 UTC) #2
Chris Masone
PTAL On 2010/05/12 19:21:12, sosa wrote: > http://codereview.chromium.org/2029009/diff/1/2 > File src/scripts/enter_chroot.sh (right): > > http://codereview.chromium.org/2029009/diff/1/2#newcode155 ...
10 years, 7 months ago (2010-05-12 20:21:39 UTC) #3
sosa
10 years, 7 months ago (2010-05-12 21:53:40 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698